Repository navigation
Run the Python 3.9 Linux CI job on ubuntu-24.04 - #761
Merged
Merged
Conversation
actions/setup-python has no Python 3.9 build for Ubuntu 26.04, which ubuntu-latest is moving to, so the (3.9, ubuntu-latest) leg fails at setup and fail-fast cancels the rest of the matrix. Run only that leg on ubuntu-24.04; the matrix and job names stay the same.
Collaborator
|
Thanks! Probably fine to just drop 3.9 from everything if it simplifies CI |
Per review: remove 3.9 from the CI matrix (and the ubuntu-24.04 pin it needed), from python_requires and the classifiers in setup.py, and from the tox envlist.
Contributor
Author
|
Done in 0322a22: 3.9 is gone from the CI matrix (so the ubuntu-24.04 pin is no longer needed and |
Collaborator
|
LGTM thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ubuntu-latestis moving to Ubuntu 26.04 (GitHub's runner-images announcement, issue 14748, planned to finish by 19 November), and actions/setup-python has no Python 3.9 build for 26.04. PR runs here are already landing on it. In run 41510521877 (PR #760, 2 November, image ubuntu-26.04) thebuild (3.9, ubuntu-latest)job stopped at itsSet up Python 3.9step withand fail-fast then cancelled the other 17 jobs, so the whole run shows as failed. Run 41510483823 on the same PR went the same way. In both runs the 3.10 to 3.14 Linux legs had already passed
make testoneandmake testredoson 26.04 before they were cancelled, so 3.9 is the only leg that breaks there. The master push run for cecee4f, on ubuntu-24.04, passed (run 41391057067).This changes the one
runs-online in.github/workflows/python.yamlso that only the (3.9, ubuntu-latest) leg runs onubuntu-24.04. The matrix values are unchanged, so the job names stay the same (that leg is still namedbuild (3.9, ubuntu-latest)) and any required checks keep matching. macOS, Windows and the other Linux legs keep their runners.What I ran: actionlint 1.7.12 on the file before and after (the same single shellcheck info note on the
pip install .[all]line both times, nothing new), and a small script that expands the matrix, evaluates theruns-onexpression, and looks up each setup-python request in the versions-manifest.json that setup-python reads. Before the change, one request (3.9 on 26.04) has no build; after it, none do, and 3.9 resolves to 3.9.25 on 24.04. I have not run the workflow itself, so the checks on this PR are the real test.I kept the 3.9 leg because
python_requiresis still>=3.9. Would you rather drop 3.9 from CI andpython_requiresinstead?